Reset database before executing TestExampleBuilder class #942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The following tests in
TestExampleBuilder.javaare detected to be order-dependent and they may fail when the execution order of tests (inbasemodule) is shuffled.Similar to the problem raised in #941, the above tests rely on a database that is original/unmodified. When some test runs before them and modifies some shared values in the database, these tests would fail because the database is polluted and properties of the database have changed.
Proposed Fix
Fix for these tests is the same as the mentioned PR. Resetting/Cleaning the database before executing tests in
TestExampleBuilderenables the tests to access a database with unchanged properties. With this fix, these tests should pass whatever the execution order is.(Detection tool is iDFlakies, please refer to https://github.com/UT-SE-Research/iDFlakies)