Skip to content

implementation of the zipkin converter started#21

Merged
Goala merged 2 commits into
abap-observability-tools:mainfrom
JohannesKonings:conv
Mar 7, 2021
Merged

implementation of the zipkin converter started#21
Goala merged 2 commits into
abap-observability-tools:mainfrom
JohannesKonings:conv

Conversation

@JohannesKonings
Copy link
Copy Markdown
Member

related to #5

@JohannesKonings JohannesKonings added patch update patch version chore maintenance update labels Mar 4, 2021
converted_trace-json = zipkin_json.

* [{
* "id": "11123456",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with all that json? 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the reminder that it's not finished. Not good, but maybe better to have some progress.

@JohannesKonings JohannesKonings marked this pull request as draft March 5, 2021 18:32
@JohannesKonings
Copy link
Copy Markdown
Member Author

added some further progress. still not finished, but every step count 😄

@JohannesKonings JohannesKonings marked this pull request as ready for review March 5, 2021 18:46
@JohannesKonings JohannesKonings requested a review from Goala March 5, 2021 18:46
Copy link
Copy Markdown
Member

@Goala Goala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Goala Goala merged commit cf07295 into abap-observability-tools:main Mar 7, 2021
@JohannesKonings JohannesKonings deleted the conv branch March 7, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore maintenance update patch update patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants