Attachment type #1358
Attachment type #1358
Conversation
coolcalcacol
changed the title
|
Is this solely for the attachment type? There is also an attachments map in command interaction. |
|
@linker-123 Is that better? |
|
Add types for attachment class |
- rename "main" to "upstream" - add "everything-v10" branch Additions: - abalabahaha/eris#1283 - abalabahaha/eris#1285 - abalabahaha/eris#1332 - abalabahaha/eris#1344 - abalabahaha/eris#1351 - abalabahaha/eris#1355 - abalabahaha/eris#1358 - abalabahaha/eris#1359 - abalabahaha/eris#1363 - abalabahaha/eris#1366 - abalabahaha/eris#1367 - abalabahaha/eris#1368 - abalabahaha/eris#1369 - abalabahaha/eris#1370 Removals: - abalabahaha/eris#1305 - abalabahaha/eris#1314 - abalabahaha/eris#1325
|
what was the conclusion with the attachments class vs just using objects? |
DonovanDMC
left a comment
DonovanDMC
left a comment
There was a problem hiding this comment.
sort properties alphabetically
DonovanDMC
left a comment
DonovanDMC
left a comment
There was a problem hiding this comment.
Why do we have both an interface and a class named Attachment? These will be combined when using Attachment, as can be seen here
|
The interface pre-dates this pr. Before I headed away I was considering merging it but that would mean processing the message to create attachment classes for each attachment |
|
That sounds like the best idea it's either that or rename one of them |
bsian03
left a comment
bsian03
left a comment
There was a problem hiding this comment.
URL is used everywhere else, not Url
Co-authored-by: bsian03 <[email protected]> Co-authored-by: TTtie <[email protected]> Co-authored-by: Donovan Daniels <[email protected]>
coolcalcacol
force-pushed
the
attachments-type
branch
from
b951a15 to
bc79188
Compare
|
|
||
| if (data.attachments) { | ||
| for (const attachment of data.attachments) { | ||
| this.attachments.add(attachment, this); |
There was a problem hiding this comment.
This needs to be able to update/delete, or overwrite completely
There was a problem hiding this comment.
I feel like some of these properties can be modified
6 participants
No description provided.