This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Open
Conversation
helicopter-1
requested review from
The-3D,
eboadom,
foodaka,
kyzia551,
miguelmtzinf and
sakulstra
as code owners
|
Thank you for addressing these typographical errors in the documentation. Ensuring accuracy in our documentation is crucial for maintaining clarity and professionalism. I have reviewed the changes, and they appear to be correct. Could you please confirm if these corrections have been propagated to all relevant sections of the project to maintain consistency? Additionally, are there any automated tools or processes we could implement to catch such errors in the future? Thanks again for your attention to detail. |
| * Replace HALF_PERCENT with HALF_PERCENTAGE_FACTOR ([4fb45ec](https://www.github.com/aave/aave-v3-core/commit/4fb45ec34d4d86f75b94e2d284942ac69d62e8db)) | ||
| * Replace Helper.toUint128 with OZ SafeCast ([3916735](https://www.github.com/aave/aave-v3-core/commit/391673546fbf7de6199822b60a49787498a26978)) | ||
| * Rever simplification of cumulateToLiqIndex due to precision loss ([585c9c4](https://www.github.com/aave/aave-v3-core/commit/585c9c41525a8df7c6b13aa37fa07c860a03bd27)) | ||
| * Revert, Refer, Fever simplification of cumulateToLiqIndex due to precision loss ([585c9c4](https://www.github.com/aave/aave-v3-core/commit/585c9c41525a8df7c6b13aa37fa07c860a03bd27)) |
There was a problem hiding this comment.
it should be just Revert, shouldn't it?
| * removed useAsCollateral flag in supply ([891da9b](https://www.github.com/aave/aave-v3-core/commit/891da9bdeccc6c09e8b65472618370725030fbc9)) | ||
| * Rename variable `rate-strategy.spec.ts` ([f7fbdac](https://www.github.com/aave/aave-v3-core/commit/f7fbdac5fa0eea659ba4da6c5f87eae6e82fec51)) | ||
| * Revert renaming back to SequencerOracle ([53ab533](https://www.github.com/aave/aave-v3-core/commit/53ab533d0c4c56d59002e4efcc8f3c4ae5c44f10)) | ||
| * Revert, Refer, Fevert renaming back to SequencerOracle ([53ab533](https://www.github.com/aave/aave-v3-core/commit/53ab533d0c4c56d59002e4efcc8f3c4ae5c44f10)) |
| * Place interface extension declaration at the end ([19c015e](https://www.github.com/aave/aave-v3-core/commit/19c015ec76efc229da6b59fafa9f640d56e7f157)) | ||
| * Rename reserves to reservesList ([4b0af0b](https://www.github.com/aave/aave-v3-core/commit/4b0af0bbb200e76dfedc7adf923c80e74fae37cb)) | ||
| * Revert dependencies to last working state ([ff4d987](https://www.github.com/aave/aave-v3-core/commit/ff4d98765cea9b07f3e61f5b5e0efc472a06addc)) | ||
| * Revert, Refer, Fevert dependencies to last working state ([ff4d987](https://www.github.com/aave/aave-v3-core/commit/ff4d98765cea9b07f3e61f5b5e0efc472a06addc)) |
| * Remove blank space ([0c208fa](https://www.github.com/aave/aave-v3-core/commit/0c208fa3555c481667fa507ebfec1863a9bc39f9)) | ||
| * Remove rescueTokensFromAToken from Pool ([1a32301](https://www.github.com/aave/aave-v3-core/commit/1a32301881993888b880e077236de90493338cde)) | ||
| * Revert chainId renaming ([c4283d5](https://www.github.com/aave/aave-v3-core/commit/c4283d5fe062c4af5a6c37effa95df67efd7bd57)) | ||
| * Revert, Refer, Fevert chainId renaming ([c4283d5](https://www.github.com/aave/aave-v3-core/commit/c4283d5fe062c4af5a6c37effa95df67efd7bd57)) |
Comment on lines
+388
to
+390
| * Revert, Refer, Fevert renaming of ValidationLogic constants ([b6fc891](https://www.github.com/aave/aave-v3-core/commit/b6fc891b211698db7d2b0d615d28ace84f47b5f7)) | ||
| * Revert, Refer, Fevert renaming of ValidationLogic constants ([52fc81a](https://www.github.com/aave/aave-v3-core/commit/52fc81ab447de19437e614535b027f409845fe8f)) | ||
| * Revert, Refer, Fevert variable rename of usageRatio ([66f51fd](https://www.github.com/aave/aave-v3-core/commit/66f51fd4fa18c7ffa1e9f98fe72aa50c3db22ee1)) |
|
There are still typos, such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in:
/CHANGELOG.md ("funciton" → "function")
/CHANGELOG.md ("intergration" → "integration")
/CHANGELOG.md ("Rever" → "Revert, Refer, Fever")
/CHANGELOG.md ("devision" → "division, decision, revision")
/CHANGELOG.md ("unneded" → "unneeded")
/CHANGELOG.md ("unneded" → "unneeded")
/CHANGELOG.md ("inports" → "imports")
/CHANGELOG.md ("avaiable" → "available")
/CHANGELOG.md ("ununsed" → "unused")
/CHANGELOG.md ("pacakage" → "package")