This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Reduce repeated checks in the SupplyLogic.sol#847
Open
tanliwei wants to merge 1 commit intoaave:masterfrom
Open
Reduce repeated checks in the SupplyLogic.sol#847tanliwei wants to merge 1 commit intoaave:masterfrom
tanliwei wants to merge 1 commit intoaave:masterfrom
Conversation
Merge two `if` branches into two-level `if` branches to save gas without changing the logic.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge two
ifbranches into a two-levelifbranches to save gas without changing the logic.The only case in this PR not covered is when the passed-in parameter
params.amountequal to userBalance that isIAToken(reserveCache.aTokenAddress).scaledBalanceOf(msg.sender).rayMul(reserveCache.nextLiquidityIndex);This pr is ok if only the value
type(uint256).maxstands for withdraw all asset.