Skip to content

Added private member yaml member attrribute regression test #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdwardCooke merged 1 commit into from
Sep 1, 2024
+23 −2
Merged

Added private member yaml member attrribute regression test #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions YamlDotNet.Test/Serialization/DeserializerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ public void SerializeStateMethodsGetCalledOnce()
Assert.Equal(1, test.OnDeserializedCallCount);
Assert.Equal(1, test.OnDeserializingCallCount);
}

[Fact]
public void DeserializeConcurrently()
{
Expand All @@ -389,7 +389,7 @@ public void DeserializeConcurrently()
// Failures don't occur consistently - running repeatedly increases the chances
RunTest();
}

Assert.Empty(exceptions);

void RunTest()
Expand Down Expand Up @@ -444,6 +444,27 @@ public void WithCaseInsensitivePropertyMatching_IgnoreCase()
Assert.Equal("Value", test.Field);
}

[Fact]
public void PrivateMembersExposeYamlMemberAttribute()
{
var yaml = "key: value";

var result = new DeserializerBuilder()
.IncludeNonPublicProperties()
.Build()
.Deserialize<PrivateYamlMemberTest>(yaml);

Assert.Equal("value", result.PublicValue);
}

class PrivateYamlMemberTest
{
[YamlMember(Alias = "key")]
private string YamlValue { get; set; } = null!;

public string PublicValue => YamlValue;
}

#if NET8_0_OR_GREATER
[Fact]
public void WithRequiredMemberSet_ThrowsWhenFieldNotSet()
Expand Down