Just a 'bureaucratic' update (jbuilder -> dune, opam -> opam 2.0) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantron
reviewed
May 2, 2020
Owner
aantron
left a comment
aantron
left a comment
There was a problem hiding this comment.
Thanks! Just have a couple nits.
Makefile
Outdated
| .PHONY : run | ||
| run : | ||
| jbuilder build --dev tester/tester.exe reporter/reporter.exe | ||
| dune build --profile=dev tester/tester.exe reporter/reporter.exe |
Owner
There was a problem hiding this comment.
I think --profile=dev could just be dropped, since it is the default.
faster-map.opam
Outdated
| opam-version: "1.2" | ||
| opam-version: "2.0" | ||
| synopsis: "A tail-recursive list map with good performance for all list sizes. Not actually written in assembly" | ||
| authors: "<Anton Bachin> [email protected]" |
Owner
There was a problem hiding this comment.
IIRC this is should be name <email>, not <name> email.
faster-map.opam
Outdated
| "containers" | ||
| "core_bench" | ||
| "jbuilder" {build & >= "1.0+beta13"} | ||
| "dune" {build & >= "1.0"} |
Owner
There was a problem hiding this comment.
dune should be a non-build dependency. See ocaml/opam-repository#14266.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you very much for your repo - I am going to use it for benchmarking TRMC. Since I need to convert it to dune anyway, I am making a PR to update your repo.
No functionality changes done, only:
jbuilder/dune/ + a small updates of command line arguments todunedune upgradeas advised bydune..opamto passopam lintforopamversion 2.1.0~beta.Please feel free to close this PR without comments and/or merging.