Skip to content

Conversation

@MahmoudMabrok
Copy link
Contributor

@MahmoudMabrok MahmoudMabrok commented Oct 27, 2024

Description

adding cache layer to save time of pipeline
making jobs of build depend on job of lint and tests so if lint fail, we do not need to run pipeline

Fixes #68

before caching
after cache

from 18m as total into 13m as total (~30% saving time)

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@MahmoudMabrok MahmoudMabrok marked this pull request as ready for review October 28, 2024 08:35
Copy link
Owner

@a-ghorbani a-ghorbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋, added a few comments.

Copy link
Owner

@a-ghorbani a-ghorbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. lgtm!

@a-ghorbani a-ghorbani merged commit 648e320 into a-ghorbani:main Oct 30, 2024
3 checks passed
EXTREMOPHILARUM pushed a commit to EXTREMOPHILARUM/pocketpal-ai that referenced this pull request Nov 4, 2024
* Update README.md

* Update ci.yml

* fix: failing test by skipping it

* fix: lint issue

* fix: skipping tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: enhance pipeline by adding cache to rpm and gradle

2 participants