feat: adding french language #317
Conversation
There was a problem hiding this comment.
This is amazing. thanks for taking the time and going through all items and translating to French 🇫🇷. merci beaucoup!
a quick note: I don't speak French myself, so I'm using an LLM to help review the translations. One has been flagged, though the model may not have full context, so it could be a false alarm. Just flagging it for your review to double-check the translation accuracy. Thanks!
src/utils/l10n.ts
Outdated
| common: { | ||
| cancel: 'Annuler', | ||
| delete: 'Supprimer', | ||
| dismiss: 'Refuser', |
There was a problem hiding this comment.
Note: I don't speak French myself, so I'm using an LLM to help review the translations. This one was flagged as potentially suboptimal, though the model may not have full context, so it could be a false alarm. Just flagging it for your review to double-check the translation accuracy. Thanks!
| Dismiss | Refuser | ⚠️ | "Refuser" means "refuse/reject". Better: "Ignorer" or "Fermer" |
There was a problem hiding this comment.
Yes, dismiss is better translated as "Fermer" in this context (I'm French).
There was a problem hiding this comment.
oh yes it's right, sorry !
Compute64bits
changed the title
Compute64bits
changed the title
|
i think is okay |
Thanks, no worries. I'll review. btw, an easy way to check if the test/linter fails locally is using these commands: > yarn lint
> yarn typecheck
> yarn test |
|
thank you for your kindness ! <3 |
|
it's good ? :) |
Hey! Sorry for the delay. I was tied up with the Vision release and just got a chance to review the PRs today. It seems the ci typecheck is failing, most likely because there are new entries in l10n.ts on main that aren't in this branch. Would you mind syncing the branch with main before we merge, just to make sure everything is in sync? |
4 participants
Description
I've added French language support :)
ps : this is my first contribution to a github project, sorry if I made mistakes 😅
Platform Affected
Checklist