Skip to content

dont connect to lotus node > 1.5.0 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jleni merged 1 commit into from
Jul 27, 2021
Merged

dont connect to lotus node > 1.5.0 #145

jleni merged 1 commit into from
Jul 27, 2021

Conversation

@rllola
Copy link
Contributor

@rllola rllola commented Jul 27, 2021

closes #134

@rllola rllola changed the base branch from master to dev July 27, 2021 12:51
@jleni
Copy link
Member

jleni commented Jul 27, 2021

this is weird

2021/07/27 13:09:09 POST /mempool 1m17.853751455s
2021-07-27T13:10:18.190Z	INFO	rosetta-filecoin-proxy	services/errors.go:366	Error on file: mempool.go:110
2021-07-27T13:10:18.190Z	ERROR	rosetta-filecoin-proxy	services/errors.go:368	Proxy: unable to get transactions | Lotus: RPC client error: sendRequest failed: unmarshaling response: context canceled
2021/07/27 13:10:18 POST /mempool/transaction 1m8.943725433s
2021-07-27T13:10:18.703Z	WARN	rosetta-filecoin-proxy	project/main.go:127	Shutting down rosetta...
2021-07-27T13:10:18.704Z	INFO	rosetta-filecoin-proxy	project/main.go:215	Exit Rosetta rpc

@jleni
Copy link
Member

jleni commented Jul 27, 2021

@rllola
I canceled the rosetta_cli test because it takes a really long time and the other was already failing

@rllola rllola requested a review from raynaudoe July 27, 2021 13:40
raynaudoe
raynaudoe approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@raynaudoe raynaudoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jleni
jleni reviewed Jul 27, 2021
View reviewed changes
main.go

srv.Logger.Info("Connected to Lotus version: ", version.String())

c, _ := semver.NewConstraint(">= 1.5")
Copy link
Member

@jleni jleni Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was very old...
I think what we eventually want is to avoid incorrect matches..
we should later make this a bit more flexible and make the 1.5 configurable
but we can leave like this for now

Copy link
Contributor Author

@rllola rllola Jul 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using NewConstraint should let us pass version constraints at build. For now it is hardcoded so I don't check the error but we could easily have that.

@jleni jleni merged commit 609ad18 into dev Jul 27, 2021
@rllola rllola deleted the fix/reject-1.5-lotus branch July 27, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jleni jleni jleni left review comments

+1 more reviewer

@raynaudoe raynaudoe raynaudoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proxy should check and abort if version <1.5.0

4 participants

@rllola @jleni @raynaudoe