Skip to content

FIX: Thought Chain UI Improvements #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wicky-zipstack merged 13 commits into from
Apr 7, 2026
Merged

FIX: Thought Chain UI Improvements #45

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8cf75e4
fix: update initial thought chain message to be more generic
tahierhussain Apr 7, 2026
196322f
refactor: consolidate PromptInfo component and remove unused code
tahierhussain Apr 7, 2026
8af3224
feat: add collapsible thought chain UI styles
tahierhussain Apr 7, 2026
d7048d6
style: apply eslint formatting fixes
tahierhussain Apr 7, 2026
89f9403
fix: only show Processing shimmer when actively streaming
tahierhussain Apr 7, 2026
d55300c
fix: hide step count when there are no previous steps
tahierhussain Apr 7, 2026
06e58fe
fix: rename local errorDetails to avoid shadowing prop
tahierhussain Apr 7, 2026
f025a76
fix: use meaningful React key for object messages
tahierhussain Apr 7, 2026
900f2f3
fix: hide header message when collapse is expanded
tahierhussain Apr 7, 2026
9986874
fix: add rounded bottom corners to collapse content
tahierhussain Apr 7, 2026
42e461b
refactor: remove unused llmModels prop from Conversation
tahierhussain Apr 7, 2026
c11d097
fix: remove overly broad disapproval reason detection
tahierhussain Apr 7, 2026
22c71e9
fix: remove stale llmModels prop passed to Conversation
tahierhussain Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/backend/application/context/llm_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def process_prompt(self, sid: str, channel_id: str, chat_id: str, chat_message_i
check_oss_api_key_configured()

self.persist_prompt_status(chat_message_id=chat_message_id, status=ChatMessageStatus.RUNNING)
content = "Preparing database information..."
content = "Gathering context..."
self.send_and_persist_thought_chain(
sid=sid,
channel_id=channel_id,
Expand Down
70 changes: 16 additions & 54 deletions frontend/src/ide/chat-ai/Conversation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import PropTypes from "prop-types";
import { Alert, Divider, Space } from "antd";

import { PromptInfo } from "./PromptInfo";
import { EnhancedPromptInfo } from "./EnhancedPromptInfo";
import { MarkdownView } from "./MarkdownView";
import { UserPrompt } from "./UserPrompt";
import { useUserStore } from "../../store/user-store";
Expand All @@ -16,7 +15,6 @@ const Conversation = memo(function Conversation({
savePrompt,
message,
chatIntents,
llmModels,
isPromptRunning,
isLastConversation,
selectedChatId,
Expand Down Expand Up @@ -67,36 +65,11 @@ const Conversation = memo(function Conversation({
return null;
}, [detectedAction]);

// Derive display names from IDs
const llmModelDisplayName = useMemo(() => {
return llmModels.find((m) => m?.model === message?.llm_model_architect)
?.display_name;
}, [llmModels, message?.llm_model_architect]);

const coderLlmModelDisplayName = useMemo(() => {
return llmModels.find((m) => m?.model === message?.llm_model_developer)
?.display_name;
}, [llmModels, message?.llm_model_developer]);

const chatIntentName = useMemo(() => {
return chatIntents.find(
(intent) => intent?.chat_intent_id === message?.chat_intent
)?.name;
}, [chatIntents, message?.chat_intent]);

// Check if we have any "thought chain" data
const isThoughtChainReceived = useMemo(() => {
return !!(message?.response?.length && message.response[0]?.length);
}, [message?.response]);

// Check if transformation is in progress
const isTransformRunning = useMemo(() => {
return message?.transformation_status === "RUNNING";
}, [message?.transformation_status]);

// Feature flag: Use enhanced UI components (can be toggled)
const useEnhancedUI = true; // Set to false to use legacy components

/** --------------------------------------------------------------------
* Derive the intent once; re-computes only when its deps change.
* ------------------------------------------------------------------- */
Expand All @@ -108,6 +81,15 @@ const Conversation = memo(function Conversation({
[chatIntents, message?.chat_intent]
);

// Memoize errorDetails to prevent unnecessary re-renders of PromptInfo
const errorDetailsMemo = useMemo(
() => ({
transformation_error_message: message?.transformation_error_message,
prompt_error_message: message?.prompt_error_message,
}),
[message?.transformation_error_message, message?.prompt_error_message]
);

return (
<div>
{/* PROMPT */}
Expand Down Expand Up @@ -141,33 +123,14 @@ const Conversation = memo(function Conversation({
</div>
)}

{/* Thought Chain - Enhanced or Legacy */}
{/* Thought Chain */}
<div className="chat-ai-conversation chat-ai-existing-chat-response-pad">
{useEnhancedUI ? (
<EnhancedPromptInfo
isThoughtChainReceived={isThoughtChainReceived}
shouldStream={isPromptRunning && isLastConversation}
thoughtChain={message?.thought_chain || []}
llmModel={llmModelDisplayName}
coderLlmModel={coderLlmModelDisplayName}
chatIntent={chatIntentName}
errorState={message?.error_state}
errorDetails={{
transformation_error_message:
message?.transformation_error_message,
prompt_error_message: message?.prompt_error_message,
}}
/>
) : (
<PromptInfo
isThoughtChainReceived={isThoughtChainReceived}
shouldStream={isPromptRunning && isLastConversation}
thoughtChain={message?.thought_chain || []}
llmModel={llmModelDisplayName}
coderLlmModel={coderLlmModelDisplayName}
chatIntent={chatIntentName}
/>
)}
<PromptInfo
shouldStream={isPromptRunning && isLastConversation}
thoughtChain={message?.thought_chain || []}
errorState={message?.error_state}
errorDetails={errorDetailsMemo}
/>
</div>

<div className="chat-ai-existing-chat-response-pad">
Expand Down Expand Up @@ -217,7 +180,6 @@ Conversation.propTypes = {
savePrompt: PropTypes.func.isRequired,
message: PropTypes.object.isRequired,
chatIntents: PropTypes.array.isRequired,
llmModels: PropTypes.array.isRequired,
isPromptRunning: PropTypes.bool.isRequired,
isLastConversation: PropTypes.bool.isRequired,
selectedChatId: PropTypes.string.isRequired,
Expand Down
Loading
Loading