-
Notifications
You must be signed in to change notification settings - Fork 622
[FIX] Add generic title+subtitle+edit pattern to ToolNavBar #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chandrasekharan-zipstack
merged 8 commits into
main
from
feat/toolnavbar-subtitle-generic
Apr 2, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fb6158e
[FIX] Add generic title+subtitle+edit pattern to ToolNavBar
chandrasekharan-zipstack 70be2f6
[FIX] Replace workflow filter toggle with static "Workflows" title
chandrasekharan-zipstack a3b64e6
[FIX] Address review comments: unused import, memoize service, guard …
chandrasekharan-zipstack 87f8027
[FIX] Wrap edit icon in Button for keyboard accessibility
chandrasekharan-zipstack 6e2124f
[FIX] Address review: guard loading state, avoid buggy updateWorkflow
chandrasekharan-zipstack 49c56d6
Merge branch 'main' into feat/toolnavbar-subtitle-generic
chandrasekharan-zipstack f346a09
[FIX] Change ToolNavBar CustomButtons prop from component function to…
chandrasekharan-zipstack 5b92eb2
Merge branch 'main' into feat/toolnavbar-subtitle-generic
athul-rs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 75 additions & 20 deletions
95
frontend/src/components/navigations/tool-nav-bar/ToolNavBar.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,86 @@ | ||
| /* Styles for ToolNavBar */ | ||
| /* ToolNavBar — top navigation bar for pages and detail views */ | ||
|
|
||
| .search-navbar-dp { | ||
| height: 25px; | ||
| width: 25px; | ||
| .tool-nav-bar { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| background-color: #184772; | ||
| border-radius: 5px; | ||
| cursor: pointer; | ||
| justify-content: space-between; | ||
| gap: 12px; | ||
| padding: 8px 12px 8px 20px; | ||
| background-color: var(--page-bg-1, #f5f7f9); | ||
| box-shadow: 0 1px 3px 0 rgba(24, 50, 71, 0.08); | ||
| border-bottom: 1px solid var(--border-color-1, #dce4e4); | ||
| } | ||
|
|
||
| .tool-nav-bar__left { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 4px; | ||
| min-width: 0; | ||
| flex: 1; | ||
| } | ||
|
|
||
| .api-search-input { | ||
| .tool-nav-bar__right { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 8px; | ||
| flex-shrink: 0; | ||
| } | ||
|
|
||
| .tool-nav-bar__search { | ||
| width: 250px; | ||
| margin-right: 10px; | ||
| } | ||
|
|
||
| .searchNav { | ||
| background-color: #f5f7f9; | ||
| padding-block: 12px; | ||
| padding-inline-start: 20px; | ||
| padding-inline-end: 12px; | ||
| height: 56px; | ||
| box-shadow: 0px 1px 3px 0px #18324714; | ||
| border: 1px solid #dce4e4; | ||
| .tool-nav-bar__segment { | ||
| background-color: rgba(0, 0, 0, 0.06); | ||
| } | ||
|
|
||
| /* Title area: hover reveals edit icon */ | ||
| .tool-nav-bar__title-area { | ||
| display: flex; | ||
| align-items: center; | ||
| min-width: 0; | ||
| flex: 1; | ||
| } | ||
|
|
||
| .tool-nav-bar__title-area:hover .tool-nav-bar__edit-icon { | ||
| opacity: 1; | ||
| } | ||
|
|
||
| /* Title + subtitle stacked, centered vertically within available height */ | ||
| .tool-nav-bar__title-group { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| min-width: 0; | ||
| } | ||
|
|
||
| /* Title text + edit icon inline */ | ||
| .tool-nav-bar__title-row { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 6px; | ||
| } | ||
|
|
||
| .tool-nav-bar__title { | ||
| font-size: var(--font-size-16, 16px); | ||
| } | ||
|
|
||
| .tool-nav-bar .tool-nav-bar__subtitle { | ||
| font-size: var(--font-size-12, 12px); | ||
| line-height: 18px; | ||
| margin-bottom: 0; | ||
| max-width: min(600px, 45vw); | ||
| } | ||
|
|
||
| /* Edit button: hidden by default, appears on title-area hover */ | ||
| .tool-nav-bar__edit-icon.ant-btn { | ||
| opacity: 0; | ||
| color: var(--ant-color-text-secondary, #8c8c8c); | ||
| transition: | ||
| opacity 0.15s, | ||
| color 0.15s; | ||
| } | ||
|
|
||
| .tool-bar-segment { | ||
| background-color: #0000000f; | ||
| .tool-nav-bar__edit-icon.ant-btn:hover { | ||
| color: var(--ant-color-primary, #1677ff); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.