feature(rpc): Extend getinfo#9261
Merged
Merged
Conversation
Contributor
|
This looks good and should work, thank you for these changes. I opened a suggestion PR (#9262) for replacing the new |
arya2
approved these changes
Feb 18, 2025
elijahhampton
pushed a commit
to elijahhampton/zebra
that referenced
this pull request
Feb 25, 2025
* introduce new fields to `GetInfo` * add address book to methods for getinfo connections field * add the version field to getinfo * track last node error or warning and display it in getinfo rpc method * add the rest of the fields, minor cleanup * fix the tests * clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Close #8448
Solution
Add fields needed.
Tests
Existing tests were updated where needed.
Follow-up Work
PR Author's Checklist
PR Reviewer's Checklist