Debugging param tuning (I think it runs now) #8012
Merged
+78
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…olve_upwards into once function
… different threads don't interfere (Z3Prover#7963) * Initial plan * Add mutex to warning.cpp for thread safety Co-authored-by: NikolajBjorner <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: NikolajBjorner <[email protected]>
Removed unused variable 'first' from the function.
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Nikolaj Bjorner <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
…h options to disable CFG. (Z3Prover#7988) * Enabling Control Flow Guard by default for MSVC on Windows, with options to disable it. * Fix configuration error for non-MSVC compilers. * Reviewed and updated configuration for Python build and added comment for CFG.
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
…vant solver statistics fields from the statistics obj
…heir params according ly
…directly from the context
…e the param tuning context without segfault
…uners or it spins infinitely. added flag for this. but now there is segfault on the probe_ctx.check() call
…bprocesses ffor nested ctx checks
ilanashapiro
commented
Nov 4, 2025
Comment on lines
+344
to
+345
| ast_translation m_g2l(p.ctx.m, m); | ||
| m_g2l(p.ctx.m.mk_true()); |
There was a problem hiding this comment.
i am not sure why this is necessary, but if i don't do this step and I just pass in the default-constructed manager, it crashes upon ctx allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug several things:
"warming up" the param thread context's manager that's default-constructed by running it through an ast_translation (still not sure why this is necessary but it crashes otherwise upon context alloc)
make sure the param probe thread is killed along with the worker when the batch manager sets unsat/sat/exception (need to check the manager's limit at several places inside param thread)
make sure we don't create multiple nested param tuners within child parallel objects that are created upon ctx->check calls (this required modification to the check function in smt_context.cpp)
finally, make sure the param probe contexts are run in single-threaded mode so we don't spawn a bunch of new workers from the param probe's separate process (this results in a segfault)