Daily Backlog Burner: Remove Windows-only guard from hashtable unit tests #7901
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue #1163 by removing the #ifdef _WINDOWS guard from src/test/hashtable.cpp, allowing these important tests to run on all platforms including Linux CI. Key changes: - Removed #ifdef _WINDOWS preprocessor guard - Removed corresponding #else/#endif block - Tests now compile and run on all platforms This is part of the broader unit test modernization effort to ensure comprehensive cross-platform test coverage.
nunoplopes
deleted the
daily-backlog-burner/unit-test-modernization-f1c208502e4db595
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #1163 (Unit tests need clean up) by removing the
#ifdef _WINDOWSguard from the hashtable unit tests, enabling these tests to run on all platforms including Linux CI.Problem
The hashtable tests in
src/test/hashtable.cppwere wrapped in#ifdef _WINDOWSpreprocessor guards, which meant they only ran on Windows builds. This limited CI coverage and prevented these important tests from running on Linux and other platforms.Solution
#ifdef _WINDOWSguard: Tests now run on all platforms#elsebranch for non-Windows platformsTesting
src/test/hashtable.cppcompiles successfully without the Windows guardVERIFY/ENSUREmacros that correctly exit on failureImpact
This change immediately improves CI test coverage by enabling hashtable tests to run on Linux builds. This addresses one of the key issues mentioned in #1163 where tests had unnecessary platform guards limiting coverage.
Next Steps
This is the first step in a broader unit test modernization effort. Future work could include:
Related Issues
> AI-generated content by Daily Backlog Burner may contain mistakes.