New python packaging and tests #7356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I removed a line that includes uploading to an audit wheel and copied part into nightly.yml where I can create local artifacts |
arbipher
pushed a commit
to arbipher/z3
that referenced
this pull request
Apr 17, 2025
* Simplify/modernize python packaging * Modify azure CI to utilize new python packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new best-practices way of building a python package looks like this:
python -m buildto generate wheelsauditwheel repairto verify that those wheels are conformant to symbol versioning standards and are tagged correctlyTo this end, I was able to simplify the python bindings build substantially. This involved making some upstream changes to auditwheel, which is generally not very happy about auditing cross builds, but it was done and my PR is pending. The "most best-practices" way of doing cross builds is to use a full container image for the target architecture and using binfmt_misc + qemu-user to perform the build and audit, but I don't think this is possible on azure.