Skip to content

Add generales var in config panel like domain, path, etc#1772

Merged
Psycojoker merged 2 commits intodevfrom
config_panel_env_vars
Mar 7, 2024
Merged

Add generales var in config panel like domain, path, etc#1772
Psycojoker merged 2 commits intodevfrom
config_panel_env_vars

Conversation

@Josue-T
Copy link
Copy Markdown
Contributor

@Josue-T Josue-T commented Feb 6, 2024

The problem

  • In config panel not all app variables are available and it limit some config file to edit correctly

Solution

  • Add env var as same as for others scripts.

PR Status

Tested on my side and it provide the necessary variables.

How to test

Run the config panel script (config) and check with env command that domain, path... are provided.

@Gredin67
Copy link
Copy Markdown
Contributor

ping @zamentur

@Josue-T Josue-T force-pushed the config_panel_env_vars branch from fbb7506 to 4705f1f Compare February 29, 2024 21:24
@Josue-T Josue-T requested a review from zamentur March 1, 2024 11:21
Copy link
Copy Markdown
Member

@Psycojoker Psycojoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Psycojoker Psycojoker merged commit 006318e into dev Mar 7, 2024
@kay0u kay0u deleted the config_panel_env_vars branch March 7, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config panels: environment not fully populated with app settings etc like for other packagingv2 scripts

3 participants