Clean redundant code. #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhanluxianshen <[email protected]>
zhanluxianshen
force-pushed
the
redundancy-code
branch
from
7294695 to
e75afd0
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant code snippets that were duplicated across several modules.
- Eliminated duplicate
if __name__ == '__main__': passblock inpdf_parse_union_core_v2_llm.py - Removed an extra
return SupportedPdfParseMethod.OCRstatement infilter/__init__.py - Cleaned up duplicate
return imagesindata/utils.py
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| magic_pdf/pdf_parse_union_core_v2_llm.py | Removed redundant __main__ block |
| magic_pdf/filter/init.py | Deleted duplicate return statement in classifier |
| magic_pdf/data/utils.py | Eliminated extra return images |
| return new_pdf_info_dict | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
[nitpick] Since the __main__ block is a no-op (pass), consider removing it entirely to reduce dead code.
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.