cred: support the hmac-secret-mc extension #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like assert, we'll need a separate struct for extension inputs versus outputs. While here, move the credBlob attribute into the new extension inputs.
We'll need this both for improved PUAT handling and `hmac-secret-mc`. While here, move early error handling up as well.
No functional change.
LDVG
force-pushed
the
hmac-secret-mc-ci
branch
from
30d6740 to
5a9548a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit -- can split this up into several parts if required.
This tries to stay mostly consistent with how we are doing this for assertions.
I have not added any example usage, tooling support, nor (potential) Windows Hello support. This will have have to be looked at separately.