cred: support requesting multiple types #837
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One function to encode the array and an internal helper to encode each member of the array. Co-Authored-By: Mofidul Jamal <[email protected]>
One function to encode the array and a helper to translate each parameter from the libfido2 representation to the winhello representation. Co-Authored-By: Mofidul Jamal <[email protected]>
Our routines check that the resulting credential is of the same type as the requested type. This means that this not a functional change. Co-Authored-By: Mofidul Jamal <[email protected]>
While here, also add `fido_int_array_contains()` helper function. Co-Authored-By: Mofidul Jamal <[email protected]>
Co-Authored-By: Mofidul Jamal <[email protected]>
Contributor
|
left a couple of comments. looks good, although i'm not sure it justifies the additional complexity. in any case, we might want to add fuzzing bits and corresponding entries to the wiredata files so that the new code paths get properly exercised. |
martelletto
reviewed
Dec 4, 2024
Co-Authored-By: Mofidul Jamal <[email protected]>
While here, use C style comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.