Skip to content

Comments

CI: WASI - Applying YoWASP changes to script #5700

Merged
mmicko merged 1 commit intomainfrom
wasi_speedup
Feb 20, 2026
Merged

CI: WASI - Applying YoWASP changes to script #5700
mmicko merged 1 commit intomainfrom
wasi_speedup

Conversation

@mmicko
Copy link
Member

@mmicko mmicko commented Feb 20, 2026

It affects linking speed so it is overall improvement on build time for WASI

@whitequark
Copy link
Member

whitequark commented Feb 20, 2026

I would be very surprised if this change resulted in a speedup. What it will change is to ensure that the resulting binary does not crash on input files with high levels of AST nesting. (Only a few levels of nesting can overflow the stack with the default 64K stack size.)

Also --stack-first causes stack overflows to result in a crash rather than silent memory corruption.

@mmicko
Copy link
Member Author

mmicko commented Feb 20, 2026

@whitequark Noticed on test-action repo, where even for SMALL=1 build it took quite a lot of time for linking, this change halfed time spent on it. Would like to see if it performs same for full build. Even if not it is good to be synced with upstream, in that case would change description.

@whitequark
Copy link
Member

Noticed on test-action repo, where even for SMALL=1 build it took quite a lot of time for linking, this change halfed time spent on it.

Oh, I guess LTO somehow makes relooper faster? Funky.

@mmicko
Copy link
Member Author

mmicko commented Feb 20, 2026

Looks like with LTO now there is 11 min for linking and previously it was instant. But on test-actions branch it was 14min link time without a change and then 15sec with, so very strange. Will wait for complete flow to finish, but it looks like I will close this one and leave as is.

@whitequark
Copy link
Member

Will wait for complete flow to finish, but it looks like I will close this one and leave as is.

Please do leave the stack-related options in: they are extremely important for correctness. The rest is up to you. But yes, the 11 min link time is mostly due to a Wasm-specific pass (relooper) and I avoid LTO except for release builds.

@mmicko mmicko changed the title CI: WASI speedup by applying YoWASP changes to script CI: WASI - Applying YoWASP changes to script Feb 20, 2026
@mmicko mmicko merged commit fb653c4 into main Feb 20, 2026
31 checks passed
@mmicko mmicko deleted the wasi_speedup branch February 20, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants