Pre-generate celltype lookup tables to fix LTO compile time regression#5699
Draft
Goubermouche wants to merge 4 commits intomainfrom
Draft
Pre-generate celltype lookup tables to fix LTO compile time regression#5699Goubermouche wants to merge 4 commits intomainfrom
Goubermouche wants to merge 4 commits intomainfrom
Conversation
Contributor
Author
|
Going to get started on unit testing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5512 implements constexpr lookups for celltype associated calls, leading to ~10% perf increase in some instances, but produces drastically longer compile times with LTO enabled. This PR aims to remedy the compile time issue while retaining the runtime performance increase.
This implementation relies on a generator script (
misc/gen_celltypes.py) to generate lookup tables once, instead of for every unit. Using this impl I achieve similar runtime characteristic as the original PR, with no visible compile time tradeoffs.TODO:
[sc-275]