Conversation
Member
|
This clearly fixes a bug that I wasted some time on, making rare use of my commit powers and merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Close #5688.
Explain how this is achieved.
Fix
PORT_B_WR_BEinADAto bePORT_A_WR_BE.Make sure your change comes with tests. If not possible, share how a reviewer might evaluate it.
Test from issue included as
tests/arch/gowin/bug5688.ys. Fails without this change (so long as thesplitnetsis there, otherwisewr_enends up in the input cone for some of the other bits), passes with.