memory_libmap: Add -force-params [sc-273]#5694
Merged
Ravenslofty merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
Reduce complexity for adi brams by unconditionally providing the WIDTH and ABITS parameters.
Member
|
Oop, thanks for splitting this and opening the PR 💜 |
widlarizer
approved these changes
Feb 20, 2026
Ravenslofty
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your work is part of a larger effort, please discuss your general plans on Discourse first to align your vision with maintainers.
What are the reasons/motivation for this change?
(This is a patch that @KrystalDelusion wrote for
synth_analogdevicesthat I thought should be pulled out of that patch series before it gets PR'd.)It can be a bit unergonomic to configure memories when the intermediate cell generated by
memory_libmapdoes not have certain size parameters.Explain how this is achieved.
Add a
-force-paramsoption to always instantiate these size parameters for more uniform mapping handling.Make sure your change comes with tests. If not possible, share how a reviewer might evaluate it.
This is admittedly a little awkward, since these are used as part of
synth_analogdevicesand as such that flow would have the testcases in question.