Merged
Conversation
mmicko
approved these changes
Feb 20, 2026
Member
mmicko
left a comment
mmicko
left a comment
There was a problem hiding this comment.
Fixes EQY test case that pointed to an issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5690. Erasing the sigbit entry entirely if no data about sigbit is required for the check to pass (for the index to track the current design as-is). Using pointer ordering for sigbits in
ModIndexis required if swap_names is supposed to be legal while holding aModIndex, otherwisestd::mapwill fail to find out-of-order entries even though it can iterate over them. Both are covered with unit tests that fail on main