fix: align light color attributes with JSON schema#115
Open
irobot wants to merge 1 commit intoYoloDev:mainfrom
Open
fix: align light color attributes with JSON schema#115irobot wants to merge 1 commit intoYoloDev:mainfrom
irobot wants to merge 1 commit intoYoloDev:mainfrom
Conversation
The discovery document for light entities declares use of JSON Schema payloads. In this format, color attribute names are abbreviated. Additionally: - the platform attribute must be "light" for Light entities - LightColorState's properties should be public, so that they are accessible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discovery document for light entities declares JSON Schema
payloads.
In this format, color attribute names are abbreviated. Consequently,
without renaming the light entity color attributes, incoming
messages are not parsed correctly.
As an example, here's a command payload, issued by HomeAssistant,
requesting that color be set to the specified hue and saturation values:
{"state":"ON","color":{"h":9.123,"s":67.059}}Per the current definition of
LightColorStatewe expecthueandsaturation, but we gethands.Changes:
LightColorStateproperties.platformis strictly"light"for light entities.LightColorState's properties public, so that they are accessible.