Change aimTarget to use Supplier<Pose2d>#40
Merged
thenetworkgrinch merged 4 commits intoYet-Another-Software-Suite:mainfrom Mar 11, 2026
Merged
Change aimTarget to use Supplier<Pose2d>#40thenetworkgrinch merged 4 commits intoYet-Another-Software-Suite:mainfrom
thenetworkgrinch merged 4 commits intoYet-Another-Software-Suite:mainfrom
Conversation
Rewrote aimTarget to be of type Optional<Supplier<Pose2d>> Added overload method for a Pose2D Added javadocs for method Only affected methods were .aim and .get under the aim case
changed .get().orElseThrow() into .orElseThrow().get
thenetworkgrinch
requested changes
Mar 11, 2026
Contributor
thenetworkgrinch
left a comment
thenetworkgrinch
left a comment
There was a problem hiding this comment.
Syntax error? Build error? I am not sure what to call this
| } else if (aimEnabled.isPresent() && aimEnabled.get().getAsBoolean()) | ||
| { | ||
| if (aimTarget.isPresent()) | ||
| if (.isPresent()) |
thenetworkgrinch
approved these changes
Mar 11, 2026
thenetworkgrinch
merged commit 65efdb9
into
Yet-Another-Software-Suite:main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote aimTarget to be of type Optional<Supplier>
Added overload method for a Pose2D
Added javadocs for method
Only affected methods were .aim and .get under the aim case