Change aimTarget from Pose2d to Supplier<Pose2d>#35
Closed
Hello2Krish19 wants to merge 1 commit intoYet-Another-Software-Suite:mainfrom
Closed
Change aimTarget from Pose2d to Supplier<Pose2d>#35Hello2Krish19 wants to merge 1 commit intoYet-Another-Software-Suite:mainfrom
Hello2Krish19 wants to merge 1 commit intoYet-Another-Software-Suite:mainfrom
Conversation
aimTarget is now an Optional<Supplier> only affected methods were the aim case in .get and the .aim method
Contributor
|
Add an overload please |
Contributor
|
I would merge this but teams already have aim as a regular function and this is a breaking change. This needs an overload before i can be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aimTarget is now an Optional
only affected methods were the aim case in .get and the .aim method