This repository was archived by the owner on Feb 16, 2026. It is now read-only.
Fix optional absolute encoder for Spark devices#298
Merged
thenetworkgrinch merged 3 commits intoYet-Another-Software-Suite:devfrom Jan 15, 2025
Merged
Conversation
thenetworkgrinch
suggested changes
Jan 15, 2025
thenetworkgrinch
suggested changes
Jan 15, 2025
Contributor
thenetworkgrinch
left a comment
thenetworkgrinch
left a comment
There was a problem hiding this comment.
Line 374 needs changed too, since it does a null check instead of an optional check too
| position = this.absoluteEncoder.get()::getAbsolutePosition; | ||
| noEncoderDefinedAlert.set(false); | ||
| } | ||
| if (absoluteEncoder == null && this.encoder.isEmpty()) |
Contributor
There was a problem hiding this comment.
This check is wrong now too
thenetworkgrinch
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the attached encoder logic to follow the optional structuring of the sparkmax, across the flex & brushed classes. Fixed the logic
isAttachedAbsoluteEncoder()