This repository was archived by the owner on Feb 16, 2026. It is now read-only.
Adding PigeonViaTalonSRX and attached SparkFlex#292
Merged
thenetworkgrinch merged 15 commits intoYet-Another-Software-Suite:devfrom Jan 23, 2025
Merged
Adding PigeonViaTalonSRX and attached SparkFlex#292thenetworkgrinch merged 15 commits intoYet-Another-Software-Suite:devfrom
thenetworkgrinch merged 15 commits intoYet-Another-Software-Suite:devfrom
Conversation
UNTESTED!!
No TalonSRX detection to attempt to see if the user has made a fault.
I had an idea like below but don't like it.
enableVoltageComp
if (!voltageComp) {
DriverStation.Error
} else {
disableVoltageComp
}
Forgot to pull the can id into the class call lol.
Contributor
|
Waiting on testing for this |
Added some basic elevator and shooter code and for now just a spark max controller.
This reverts commit 5e9fb6e.
Added roughly by copying the existing SparkMaxEncoderSwerve and making very minor tweaks under the assumption sparkflex and max are similar enough as I have not used them.
thenetworkgrinch
changed the title
Contributor
|
I am not merging this with the changes to |
thenetworkgrinch
suggested changes
Jan 20, 2025
Member
Author
|
Requested changes have been made. |
thenetworkgrinch
suggested changes
Jan 21, 2025
Contributor
thenetworkgrinch
left a comment
thenetworkgrinch
left a comment
There was a problem hiding this comment.
Pedantic changes, i know. Sorry!
Member
Author
|
I believe it should be fixed now. |
thenetworkgrinch
suggested changes
Jan 21, 2025
Contributor
thenetworkgrinch
left a comment
thenetworkgrinch
left a comment
There was a problem hiding this comment.
Just some things i found in this review. These are breaking changes that need to be corrected. Thank you again for this!
src/main/java/frc/robot/subsystems/swervedrive/SwerveSubsystem.java
Outdated
Show resolved
Hide resolved
Member
Author
|
I should have these changes ready around 7pm EST shortly after I get off work. |
Member
Author
|
Fixed the incomplete SparkFlex implementation. Ctrl-F'ed it so all SparkMax occurrences in SparkFlexEncoderSwerve have been fixed. Along with the accidental added line from testing. |
thenetworkgrinch
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encoder type is : pigeon_via_talonsrx
The can id should be that of the talon that it is attached to.
My local has a function to get the talon so it can be used without being created again.
Trying to work on a thrown error that tells the user the can id should be that of the talon's when the object is not created correctly.
Remade, it was using my main. Thx WispySparks for letting me know.