Some color manipulation nodes lose color profile information

[Banane9]

Describe the bug?

Some of the color channel manipulation nodes lose color profile information.

To Reproduce

• Create Multiply and Add nodes for a channel
• Create a color input for them and displays for the input and outputs
• Observe that the input and output of Multiply have a linear profile, while Add has sRGB

Expected behavior

Color profile should be kept regardless of operation

Screenshots

Resonite Version Number

2023.10.18.449

What Platforms does this occur on?

Windows, Linux, Android / Quest

What headset if any do you use?

Index

Log Files

This doesn't appear in the log.

Additional Context

This is an issue in the implementation of the methods on colorX, where the profile isn't passed to the newly created instances.

Reporters

Banane9
ShadowPanther

[LexiBasilisk]

Would you mind compiling a list of the nodes this behaviour occurs in, @Banane9?

Otherwise- I've confirmed this issue still occurs.

[LexiBasilisk]

This also seems like it might be related to #316.

[Banane9]

colorX Methods I found that discard the color profile:

• NormalizeHDR
• MulA (MultiplyA has it though, and all other Mul methods are implemented through their Multiply counterparts)
• AddR and _HDR
• AddG and _HDR
• AddB and _HDR
• AddA
• AlphaBlend
• AdditiveBlend
• SoftAdditiveBlend

[LexiBasilisk]

Thank you!