NaN == NaN

[mpmxyz]

Describe the bug?

https://learn.microsoft.com/en-us/dotnet/api/system.double.nan?view=net-8.0
describes that NaN values are not equal to anything when using the equality operator. (including itself -> matches IEEE 754)
But ValueEquals<float> "==" doesn't behave like that. It even considers two different NaNs as equal.

To Reproduce

Just compare some NaNs:

Expected behavior

None of the comparisons should be true.

Screenshots

No response

Resonite Version Number

Beta 2023.12.21.1127

What Platforms does this occur on?

Windows

What headset if any do you use?

No response

Log Files

ANONYMOUS - 2023.12.21.1127 - 2024-01-02 10_28_23.log

Additional Context

No response

Reporters

No response

[Banane9]

This is the standard behavior of the default EqualityComparer for floats: https://learn.microsoft.com/en-us/dotnet/api/system.collections.istructuralequatable?view=net-9.0

Changing this would require a custom implementation as shown in the sample.

[Banane9]

This also affects the ValueEqualityDriver when Approximate comparison is not active, since it also uses the default EqualityComparer.
And of course for floats and doubles.