Skip to content

Stephen/annotation dev #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 25, 2022
Merged

Stephen/annotation dev #15

merged 6 commits into from
Nov 25, 2022

Conversation

@StephenYin01
Copy link
Collaborator

@StephenYin01 StephenYin01 commented Nov 3, 2022

Fixed 2 bugs:

  1. Exec result for a correct annotation was not being saved in jsonl file because of empty string return for annotation_tasks/check_annotation_correctness
  2. 'cancel' for a correct annotation was still saving result which would mess up annotation next time the annotation tool was started again (due to a check for annotation examples to match data file)

Added new UI enhancements for ease of location return, commands, and SQL problem

Stephen Yin and others added 2 commits November 2, 2022 19:09
@StephenYin01 StephenYin01 changed the base branch from main to ansong/annotation-dev November 10, 2022 01:21
@StephenYin01 StephenYin01 self-assigned this Nov 10, 2022
niansong1996
niansong1996 reviewed Nov 25, 2022
View reviewed changes
Copy link
Contributor

@niansong1996 niansong1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niansong1996 niansong1996 merged commit 5e6b374 into ansong/annotation-dev Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niansong1996 niansong1996 niansong1996 left review comments

Assignees

@StephenYin01 StephenYin01

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StephenYin01 @niansong1996