Innermost hasAwaitStarted catch block is a no-op and could be omitted

[jnm2]

How can !hasAwaitStarted_a_1_1 in the catch block ever not evaluate to false? It's not assigned anywhere else.

stronginject/StrongInject.Tests.Unit/GeneratorTests.cs

Lines 7112 to 7125 in 2143d9f

	try
	{
	hasAwaitStarted_a_1_1 = true;
	await a_1_1;
	}
	catch
	{
	if (!hasAwaitStarted_a_1_1)
	{
	_ = a_1_1.AsTask().ContinueWith(failedTask => _ = failedTask.Exception, global::System.Threading.Tasks.TaskContinuationOptions.OnlyOnFaulted);
	}
	throw;
	}

[YairHalberstadt]

In that particular case you are right. If you want an example where this is relevant check out the testInstancePerDependencyDependenciesWithFactories. In that example async calls are parallelized - so we trigger 2 async calls then await one, then await the other. In that case you can have a situation where you need to keep track of whether an await has started.

We definitely could improve codegen to detect this scenario and remove the unnecessary bookkeeping.

[jnm2]

Makes sense. I'm not too concerned. Do you want to leave this issue open to track skipping this try block for the innermost await?

[YairHalberstadt]

Yep, thanks