trie, core/types: implement stacktrie and DerivableList interface #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* trie: update tests to check commit integrity * trie: polish committer * trie: fix typo * trie: remove hasvalue notion According to the benchmarks, type assertion between the pointer and interface is extremely fast. BenchmarkIntmethod-12 1000000000 1.91 ns/op BenchmarkInterface-12 1000000000 2.13 ns/op BenchmarkTypeSwitch-12 1000000000 1.81 ns/op BenchmarkTypeAssertion-12 2000000000 1.78 ns/op So the overhead for asserting whether the shortnode has "valuenode" child is super tiny. No necessary to have another field. * trie: linter nitpicks Co-authored-by: Martin Holst Swende <[email protected]>
* trie: polish commit function * trie: fix typo
* trie: fix error in stacktrie not committing small roots * trie: improved tests * trie: fix error in stacktrie with small nodes * trie: add (skipped) testcase for stacktrie * trie: fix docs in stacktrie
The stacktrie is a bit un-untuitive, API-wise: since it mutates input values. Such behaviour is dangerous, and easy to get wrong if the calling code 'forgets' this quirk. The behaviour is fixed by this PR, so that the input values are not modified by the stacktrie. Note: just as with the Trie, the stacktrie still references the live input objects, so it's still _not_ safe to mutate the values form the callsite.
* Add missing copyright header * Update stacktrie_test.go Co-authored-by: Péter Szilágyi <[email protected]>
Trim the search key from head as it's being pushed deeper into the trie. Previously the search key was never modified but each node kept information how to slice and compare it in keyOffset. Now the keyOffset is not needed as this information is included in the slice of the search key. This way the keyOffset can be removed and key manipulation simplified.
gzliudan
changed the title
gzliudan
changed the title
benjamin202410
approved these changes
Apr 7, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 8, 2025
gzliudan
added a commit
that referenced
this pull request
Apr 8, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 12, 2025
XinFinOrg#933 (XinFinOrg#939)" This reverts commit 0cc4813.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 14, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 16, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick the following PRs from geth:
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that