Skip to content

core/rawdb: separate raw database access to own package #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

core/rawdb: separate raw database access to own package #788

merged 1 commit into from
Jan 22, 2025

Conversation

@JukLee0ira
Copy link

@JukLee0ira JukLee0ira commented Jan 2, 2025 •
edited
Loading

Proposed changes

Move the functions from the file core/database_util.go to the rawdb package.

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@JukLee0ira JukLee0ira force-pushed the Migrate-to-rawdb branch 9 times, most recently from e8f4e36 to 773f838 Compare January 3, 2025 09:41
gzliudan
gzliudan reviewed Jan 16, 2025
View reviewed changes
gzliudan
gzliudan reviewed Jan 16, 2025
View reviewed changes
gzliudan
gzliudan reviewed Jan 16, 2025
View reviewed changes
gzliudan
gzliudan reviewed Jan 16, 2025
View reviewed changes
gzliudan
gzliudan reviewed Jan 16, 2025
View reviewed changes
core/rawdb/accessors_chain.go Outdated
Copy link
Collaborator

@gzliudan gzliudan Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ReadTdRLP

gzliudan
gzliudan reviewed Jan 16, 2025
View reviewed changes
gzliudan
gzliudan reviewed Jan 16, 2025
View reviewed changes
gzliudan
gzliudan reviewed Jan 16, 2025
View reviewed changes
@JukLee0ira JukLee0ira force-pushed the Migrate-to-rawdb branch 5 times, most recently from 84df41e to 5b697dd Compare January 17, 2025 11:26
@gzliudan
Copy link
Collaborator

gzliudan commented Jan 17, 2025

please try to reduce the call of append

@JukLee0ira JukLee0ira force-pushed the Migrate-to-rawdb branch 2 times, most recently from 4380e0a to 70cc38c Compare January 20, 2025 05:57
@gzliudan gzliudan changed the title [WIP] core/rawdb: separate raw database access to own package core/rawdb: separate raw database access to own package Jan 20, 2025
@JukLee0ira JukLee0ira force-pushed the Migrate-to-rawdb branch 2 times, most recently from 6429849 to 455b6f1 Compare January 20, 2025 06:04
gzliudan
gzliudan reviewed Jan 21, 2025
View reviewed changes
@gzliudan gzliudan mentioned this pull request Jan 21, 2025
Closed
20 tasks
@JukLee0ira JukLee0ira force-pushed the Migrate-to-rawdb branch 2 times, most recently from 3eda297 to b8b7b17 Compare January 21, 2025 07:43
@gzliudan gzliudan changed the title core/rawdb: separate raw database access to own package core/rawdb: separate raw database access to own package (#16666) Jan 22, 2025
@gzliudan gzliudan changed the title core/rawdb: separate raw database access to own package (#16666) core/rawdb: separate raw database access to own package Jan 22, 2025
@gzliudan gzliudan merged commit adba311 into XinFinOrg:dev-upgrade Jan 22, 2025
8 checks passed
@gzliudan gzliudan mentioned this pull request Jan 23, 2025
Closed
@JukLee0ira JukLee0ira deleted the Migrate-to-rawdb branch March 18, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gzliudan gzliudan gzliudan approved these changes

@benjamin202410 benjamin202410 benjamin202410 approved these changes

@wjrjerome wjrjerome Awaiting requested review from wjrjerome

@liam-lai liam-lai Awaiting requested review from liam-lai

@wgr523 wgr523 Awaiting requested review from wgr523

@wanwiset25 wanwiset25 Awaiting requested review from wanwiset25

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JukLee0ira @gzliudan @benjamin202410