In-memory aie-translate should not inherit aiesim flag from aiecc#2964
Open
In-memory aie-translate should not inherit aiesim flag from aiecc#2964
Conversation
AIETranslateToCDODirect now always uses aieSim=false CDO generation is a binary artifact step, not a simulation step, regardless of what --aiesim is set to on the command line.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures CDO artifact generation in the C++ aiecc driver is treated as a hardware/binary artifact step and no longer inherits the --aiesim simulation setting.
Changes:
- Update
aiecc.cppto callAIETranslateToCDODirectwithaieSim=falseunconditionally during CDO generation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Coverage ReportCreated: 2026-03-13 01:44Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 18.1.3 |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiecc.cppcall ofAIETranslateToCDODirectto always useaieSim=false--aiesimis set to on the command line.