Open
Conversation
Removed workaround for Peano -O2 miscompilation issue.
Removed workaround for Peano -O2 miscompilation issue.
jgmelber
changed the title
jgmelber
changed the title
jgmelber
requested review from
andrej,
fifield,
hunhoffe,
jackl-xilinx and
pvasireddy-amd
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a temporary compiler workaround from two vision example Makefiles. The workaround had downgraded the Peano compiler optimization level from -O2 to -O1 for AIE2P targets to avoid a miscompilation issue with aie::lt/aie::select loops. Now that the upstream llvm-aie fix is presumably available, the workaround is no longer needed and both Makefiles will use the default -O2 flags defined in programming_examples/makefile-common.
Changes:
- Removed the
PEANOWRAP2P_FLAGSoverride (substituting-O2with-O1) fromedge_detect/Makefileandcolor_threshold/Makefile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
programming_examples/vision/edge_detect/Makefile |
Removed 5-line workaround block that downgraded Peano optimization to -O1 for AIE2P |
programming_examples/vision/color_threshold/Makefile |
Removed identical 5-line workaround block that downgraded Peano optimization to -O1 for AIE2P |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed workaround for Peano -O2 miscompilation issue.