Check for liquid errors during linting#2815
Merged
Conversation
Collaborator
Author
|
Script caught error during linting that looked like this: Now I'm going to try fixing the error to see if it passes. |
hunhoffe
changed the title
hunhoffe
requested review from
AndraBisca,
andrej,
erwei-xilinx,
fifield,
jackl-xilinx,
jgmelber and
stephenneuendorffer
as code owners
jgmelber
approved these changes
Jan 14, 2026
andrej
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fifield correctly mentioned that it would be nice to be more programmatic about detecting and reporting liquid errors. This PR introduces a script that can do this for .td files, and integrates that script into the CI linting job.