lit.cfg.py refactor detection and other common logic into helper utility#2661
Merged
fifield merged 12 commits intoXilinx:mainfrom Oct 24, 2025
Merged
lit.cfg.py refactor detection and other common logic into helper utility#2661fifield merged 12 commits intoXilinx:mainfrom
fifield merged 12 commits intoXilinx:mainfrom
Conversation
fifield
force-pushed
the
lit_cfg_refactor
branch
from
e9af121 to
6cce4eb
Compare
fifield
changed the title
fifield
changed the title
fifield
requested review from
AndraBisca,
andrej,
denolf,
jackl-xilinx,
jgmelber,
pvasireddy-amd and
stephenneuendorffer
as code owners
fifield
force-pushed
the
lit_cfg_refactor
branch
from
bd8ded3 to
e013f5e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
… improve error decoding - Fix path normalization logic in prepend_path() to always normalize paths even when there's no existing PATH (suggestion #3) - Add XRT bin path prepending to programming_examples and programming_guide lit.cfg.py files to ensure more recent aiebu-asm is used (suggestion #2) - Add error decoding robustness in detect_peano() using errors='ignore' parameter for consistency with detect_rocm() and detect_xrt() (suggestion #4)
fifield
force-pushed
the
lit_cfg_refactor
branch
from
ebe89f4 to
e4c2ab8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
fifield
added a commit
to fifield/mlir-aie
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor of the multiple lit.cfg.py in the repo. Each of these contains cut-and-paste of the same bits of logic which must be updated in 3-4 places each time it changes. This PR proposed moving some of that into a helper utility instead.