Fix Docker run script to prevent invalid reference format

docker_run.sh

@@ -2,13 +2,13 @@
 # Copyright 2022 Xilinx Inc.
 
 confirm() {
-  echo -en "\n\nDo you agree to the terms and wish to proceed [y/n]? "
-  read REPLY
-  case $REPLY in
-    [Yy]) ;;
-    [Nn]) exit 0 ;;
-    *) confirm ;;
-  esac
+    echo -en "\n\nDo you agree to the terms and wish to proceed [y/n]? "
+    read REPLY
+    case $REPLY in
+        [Yy]) ;;
+        [Nn]) exit 0 ;;
+        *) confirm ;;
+    esac
     REPLY=''
 }
 
@@ -18,18 +18,16 @@ if [[ "$1" == "-h" || "$1" == "--help" ]]; then
 fi
 
 if [ -z "$1" ]; then
-   echo "Usage: $0 <Vitis_AI_DOCKER_NAME>"
-   exit 2
+    echo "Usage: $0 <Vitis_AI_DOCKER_NAME>"
+    exit 2
 fi
 
-
-HERE=$(pwd -P) # Absolute path of current directory
-user=`whoami`
-uid=`id -u`
-gid=`id -g`
+HERE=$(pwd -P)
+user=$(whoami)
+uid=$(id -u)
+gid=$(id -g)
 
 DOCKER_REPO="xilinx/"
-
 BRAND=vitis-ai
 VERSION=latest
 
@@ -39,108 +37,82 @@ IMAGE_NAME="$1"
 DEFAULT_COMMAND="bash"
 
 if [[ $# -gt 0 ]]; then
-  shift 1;
-  DEFAULT_COMMAND="$@"
-  if [[ -z "$1" ]]; then
-    DEFAULT_COMMAND="bash"
-  fi
+    shift 1
+    DEFAULT_COMMAND="$@"
+    [[ -z "$1" ]] && DEFAULT_COMMAND="bash"
 fi
 
-DETACHED="-it"
-
-xclmgmt_driver="$(find /dev -name xclmgmt\*)"
-docker_devices=""
-for i in ${xclmgmt_driver} ;
-do
-  docker_devices+="--device=$i "
-done
-
-render_driver="$(find /dev/dri -name renderD\*)"
-for i in ${render_driver} ;
-do
-  docker_devices+="--device=$i "
-done
-
-kfd_driver="$(find /dev -name kfd\*)"
-for i in ${kfd_driver} ;
-do
-    docker_devices+="--device=$i "
+# Device detection (minimal change)
+docker_devices=()
+for i in /dev/xclmgmt* /dev/dri/renderD* /dev/kfd*; do
+    [[ -e "$i" ]] && docker_devices+=(--device "$i")
 done
 
 DOCKER_RUN_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 if [ "$HERE" != "$DOCKER_RUN_DIR" ]; then
-  echo "WARNING: Please start 'docker_run.sh' from the Vitis-AI/ source directory";
+    echo "WARNING: Please start 'docker_run.sh' from the Vitis-AI/ source directory"
 fi
 
-docker_run_params=$(cat <<-END
-    -v /dev/shm:/dev/shm \
-    -v /opt/xilinx/dsa:/opt/xilinx/dsa \
-    -v /opt/xilinx/overlaybins:/opt/xilinx/overlaybins \
-    -e USER=$user -e UID=$uid -e GID=$gid \
-    -v $DOCKER_RUN_DIR:/vitis_ai_home \
-    -v $HERE:/workspace \
-    -w /workspace \
-    --rm \
-    --network=host \
-    ${DETACHED} \
-    ${RUN_MODE} \
-    $IMAGE_NAME \
-    $DEFAULT_COMMAND
-END
-)
-
-##############################
 
 if [[ ! -f ".confirm" ]]; then
 
     if [[ $IMAGE_NAME == *"gpu"* ]]; then
         arch="gpu"
     elif [[ $IMAGE_NAME == *"rocm"* ]]; then
-        arch='rocm'
+        arch="rocm"
     else
-        arch='cpu'
+        arch="cpu"
     fi
 
-prompt_file="./docker/dockerfiles/PROMPT/PROMPT_${arch}.txt"
+    prompt_file="./docker/dockerfiles/PROMPT/PROMPT_${arch}.txt"
 
-  sed -n '1, 5p' $prompt_file
-  read -n 1 -s -r -p "Press any key to continue..." key
+    sed -n '1, 5p' $prompt_file
+    read -n 1 -s -r -p "Press any key to continue..." key
 
-  sed -n '5, 15p' $prompt_file
-  read -n 1 -s -r -p "Press any key to continue..." key
+    sed -n '5, 15p' $prompt_file
+    read -n 1 -s -r -p "Press any key to continue..." key
 
-  sed -n '15, 28p' $prompt_file
-  read -n 1 -s -r -p "Press any key to continue..." key
+    sed -n '15, 28p' $prompt_file
+    read -n 1 -s -r -p "Press any key to continue..." key
 
-  sed -n '28, 61p' $prompt_file
-  read -n 1 -s -r -p "Press any key to continue..." key
+    sed -n '28, 61p' $prompt_file
+    read -n 1 -s -r -p "Press any key to continue..." key
 
-  sed -n '62, 224p' $prompt_file
-  read -n 1 -s -r -p "Press any key to continue..." key
+    sed -n '62, 224p' $prompt_file
+    read -n 1 -s -r -p "Press any key to continue..." key
 
-  sed -n '224, 308p' $prompt_file
-  read -n 1 -s -r -p "Press any key to continue..." key
+    sed -n '224, 308p' $prompt_file
+    read -n 1 -s -r -p "Press any key to continue..." key
 
-  sed -n '309, 520p' $prompt_file
-  read -n 1 -s -r -p "Press any key to continue..." key
-  
-  confirm
+    sed -n '309, 520p' $prompt_file
+    read -n 1 -s -r -p "Press any key to continue..." key
+
+    confirm
 fi
 
-touch .confirm 
-docker pull $IMAGE_NAME 
+touch .confirm
+docker pull "$IMAGE_NAME"
+docker_run_params=(
+    -v /dev/shm:/dev/shm
+    -v /opt/xilinx/dsa:/opt/xilinx/dsa
+    -v /opt/xilinx/overlaybins:/opt/xilinx/overlaybins
+    -e USER="$user"
+    -e UID="$uid"
+    -e GID="$gid"
+    -v "$DOCKER_RUN_DIR:/vitis_ai_home"
+    -v "$HERE:/workspace"
+    -w /workspace
+    --rm
+    --network=host
+    -it
+    "$IMAGE_NAME"
+    "$DEFAULT_COMMAND"
+)
+
 if [[ $IMAGE_NAME == *"gpu"* ]]; then
-  docker run \
-    $docker_devices \
-    --gpus all \
-    $docker_run_params
+    docker run --gpus all "${docker_devices[@]}" "${docker_run_params[@]}"
 elif [[ $IMAGE_NAME == *"rocm"* ]]; then
-  docker run \
-    $docker_devices \
-    --group-add=render --group-add video --ipc=host --cap-add=SYS_PTRACE --security-opt seccomp=unconfined \
-    $docker_run_params
+    docker run --group-add=render --group-add video --ipc=host --cap-add=SYS_PTRACE --security-opt seccomp=unconfined "${docker_devices[@]}" "${docker_run_params[@]}"
 else
-  docker run \
-    $docker_devices \
-    $docker_run_params
+    docker run "${docker_devices[@]}" "${docker_run_params[@]}"
 fi