Add authenticating to the XcodeInstallationStep
#613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuganzy
force-pushed
the
ganzy/rollback-loading
branch
from
b5a5bb0 to
984d952
Compare
chuganzy
force-pushed
the
ganzy/rollback-loading
branch
from
984d952 to
908e7ba
Compare
chuganzy
changed the title
isProcessing(id: Xcode.ID) -> Bool to the AppStateauthenticating step to the AppState
chuganzy
changed the title
authenticating step to the AppStateauthenticating step to the XcodeInstallationStep
chuganzy
changed the title
authenticating step to the XcodeInstallationStepauthenticating to the XcodeInstallationStep
chuganzy
commented
Sep 22, 2024
| "ja" : { | ||
| "stringUnit" : { | ||
| "state" : "translated", | ||
| "value" : "認証中" |
Contributor
Author
There was a problem hiding this comment.
Added only Japanese as it is my primary language but want the community help for others!
MattKiazyk
requested changes
Oct 11, 2024
Contributor
MattKiazyk
left a comment
MattKiazyk
left a comment
There was a problem hiding this comment.
Can we please add Authenticating as the value for all languages? This will be default for all languages and needs to be unfortunately added
Contributor
|
Thanks @chuganzy - just one change with adding the localization values for all the languages. 🙏 |
Contributor
Author
|
@MattKiazyk Thank you for reviewing & merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #551
Thanks for creating this awesome app!
This PR aims to fix a minor issue where it keeps displaying the indicator on the install button on error.
To fix it, this PR introduces
authenticatingstate to theXcodeInstallationStepand makes it to theinstallingstate once "INSTALL" button is clicked.Screen Capture
Before
before.mov
After
after.mov