Skip to content

Conversation

@aerickson14
Copy link
Contributor

What's changed

  • Removed the functionality where authentication errors would present an alert

  • Added an inline error message to the sign in view for authentication errors
    Screen Shot 2021-05-01 at 9 14 32 AM

  • Handle the case where authentication responds with an account locked error
    Screen Shot 2021-05-01 at 9 14 44 AM

How to test

  • From an unauthenticated state open up the sign in view either from preferences or the icon in the menu bar
  • Fill in your username but provide an incorrect password
  • You should see an inline error message "Invalid username and password combination"
  • Tapping cancel or next should clear this error message
  • If you input a username that is common/short/not an email address like "test" the app will now show a proper error message for account locked. Previously this would generate an alert of the form "Received an unexpected sign in response."

@aerickson14 aerickson14 added the enhancement New feature or request label May 1, 2021
@aerickson14 aerickson14 requested a review from a team as a code owner May 1, 2021 15:22
@aerickson14 aerickson14 requested a review from MattKiazyk May 1, 2021 15:22
Copy link
Contributor

@MattKiazyk MattKiazyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
So much cleaner - thanks!

@MattKiazyk MattKiazyk merged commit ffc7223 into andrew/signIn May 2, 2021
@MattKiazyk MattKiazyk deleted the andrew/signInErrorHandling branch May 2, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants