Sockopt: Allow listen v6only work for Windows & Darwin
#4571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
我记得你加过好多 sockopt，不会都是 linux 的、没带上 win 和 mac 吧？要不你排查一下一个 PR 内全解决了，不要一个个 PR |
Member
|
|
Contributor
Author
是这样，因为以前只知道 Linux 写法。 |
Member
|
一个 PR 只做一件事是对的，但有很多 typo 时总不能一个 typo 开一个 pr 吧，把三个主要系统的 sockopt 对齐、一个 PR 解决吧 freebsd 就不抢救了，因为我看到 Xray 的 releases 里还有 openbsd，算了，谁用谁写吧 |
Member
|
可以把 custom sockopt 开放到这几个系统 |
RPRX
changed the title
V6Onlyv6only work for Windows & Darwin
RPRX
changed the title
v6only work for Windows & Darwinv6only work for Windows & Darwin
RPRX
added a commit
that referenced
this pull request
Mar 31, 2025
Completes #1677 --------- Co-authored-by: RPRX <[email protected]>
Member
|
我把 Darwin 的代码加上了，应该能用，月底了想发个 3 月累积更新版本，先测测最近的修改有没有问题 |
This was referenced Apr 1, 2025
1 task
maoxikun
pushed a commit
to maoxikun/Xray-core
that referenced
this pull request
Aug 23, 2025
Completes XTLS#1677 --------- Co-authored-by: RPRX <[email protected]> (cherry picked from commit 2abeda9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1677