Skip to content

Chore: Improved log messaging#4050

Merged
yuhan6665 merged 2 commits intoXTLS:mainfrom
red-avtovo:patch-1
Nov 25, 2024
Merged

Chore: Improved log messaging#4050
yuhan6665 merged 2 commits intoXTLS:mainfrom
red-avtovo:patch-1

Conversation

@red-avtovo
Copy link
Contributor

@red-avtovo red-avtovo commented Nov 21, 2024

There is a line that appeared in my logs that is quite ambiguous. Only after reading the source code could I understand what that meant. Fixing that to make the reason for the Warn clearer

inbound.CanSpliceCopy = 3
if account.Flow == vless.XRV && (request.Command == protocol.RequestCommandTCP || isMuxAndNotXUDP(request, first)) {
return errors.New(account.ID.String() + " is not able to use \"\". Note that the pure TLS proxy has certain TLS in TLS characters.").AtWarning()
return errors.New("account " + account.ID.String() + " is not able to use the flow \"none\". Note that the pure TLS proxy has certain TLS in TLS characters.").AtWarning()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no such flow as "none". Maybe better to say
..is rejected since the client flow is empty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it makes sense. I will update the wording

@yuhan6665 yuhan6665 changed the title Improved log messaging Chore: Improved log messaging Nov 25, 2024
@yuhan6665 yuhan6665 merged commit d8934cf into XTLS:main Nov 25, 2024
@yuhan6665
Copy link
Member

Thanks!

@red-avtovo red-avtovo deleted the patch-1 branch November 25, 2024 17:06
it2konst pushed a commit to it2konst/gametunnel-core that referenced this pull request Mar 1, 2026
* update log messages

* Update inbound.go
drovosek229 pushed a commit to drovosek229/Xray-core that referenced this pull request Mar 16, 2026
* update log messages

* Update inbound.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants