SplitHTTP client: Fix xmux config deserialization#3827
Merged
Conversation
During the rename, it seems the parameters were defined with the wrong visibility, which means they are always deserialized as nil. Basically xmux doesn't work right now in the latest release due to this.
Member
|
正好我想了一下，都默认为 0 的话无限复用实际上是 maxConcurrency 主导的，所以应当把它放到 maxConnections 上面 @Fangliding 文档也改下顺序 |
Member
|
Member
|
proto 序号 |
RPRX
changed the title
Member
|
@Fangliding 文档需要更新：
|
Member
有点点哭笑不得 maxconcurrency我昨天就改掉了 但是没改上面的config实例部分 后来mmm也来改了 把config示例和下面的解释一起对调了 结果就是config示例对了但是下头我换上来的 maxconcurrency又被换下去了 今早检查的时候还纳闷怎么昨天编辑了怎么没变 对于一个有默认行为的机器 插入一个可选controller对其行为进行更精细的控制不少作品其实都有 很少有把它叫limit的（虽然有时候确实是这个作用） 所以我之前写的时候没提 其实h2复用也不是无限的 golang默认最大stream好像是100 而且这个控制器的流扫过一眼discussion这个concurrency好像不是控制的具体h2流而是整个splithttp 它产生的http请求肯定不止一条 最少也是两条 所以真正的concurrency可能也就几十？ |
Member
你深究一下，可能需要改掉，不过不知道那些反代软件有没有限制，你查一下 |
leninalive
pushed a commit
to amnezia-vpn/amnezia-xray-core
that referenced
this pull request
Oct 29, 2024
dragonbreath2000
pushed a commit
to dragonbreath2000/Xray-core
that referenced
this pull request
Dec 11, 2024
dragonbreath2000
pushed a commit
to dragonbreath2000/Xray-core
that referenced
this pull request
Dec 12, 2024
it2konst
pushed a commit
to it2konst/gametunnel-core
that referenced
this pull request
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the rename, it seems the parameters were defined with the wrong visibility, which means they are always deserialized as nil. Basically xmux doesn't work right now in the latest release due to this.