Fix int overflow on x32 processors causing panic using burstObservatory #3810
Conversation
During the roll, "duration" is converted to int, causing overflow on x32 processors. The value may be very small or negative, causing a panic in rand.Intn.
Member
|
Looks good. Thank you! |
Member
leninalive
pushed a commit
to amnezia-vpn/amnezia-xray-core
that referenced
this pull request
Oct 29, 2024
During the roll, "duration" is converted to int, causing overflow on x32 processors. The value may be very small or negative, causing a panic in rand.Intn.
dragonbreath2000
pushed a commit
to dragonbreath2000/Xray-core
that referenced
this pull request
Dec 11, 2024
During the roll, "duration" is converted to int, causing overflow on x32 processors. The value may be very small or negative, causing a panic in rand.Intn.
dragonbreath2000
pushed a commit
to dragonbreath2000/Xray-core
that referenced
this pull request
Dec 12, 2024
During the roll, "duration" is converted to int, causing overflow on x32 processors. The value may be very small or negative, causing a panic in rand.Intn.
it2konst
pushed a commit
to it2konst/gametunnel-core
that referenced
this pull request
Mar 1, 2026
During the roll, "duration" is converted to int, causing overflow on x32 processors. The value may be very small or negative, causing a panic in rand.Intn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using burstObservatory I get a panic on the mipsle processor. During the roll, "duration" is converted to int, causing overflow on x32 processors. The value may be very small, causing private queries, or negative, causing a panic in rand.Intn.
Version:
Xray 1.8.18 (Xray, Penetrates Everything.) 9e6d7a3c (go1.22.5 linux/mipsle)Config burstObservatory:
{ "burstObservatory": { "subjectSelector": ["proxy"], "pingConfig": { "destination": "https://connectivitycheck.gstatic.com/generate_204", "connectivity": "", "interval": "30s", "sampling": 3, "timeout": "3s" } } }Stdout: