Config: Remove legacy inbound/outbound/detours#3769
Conversation
|
这些不像 看起来我们正在执行 #1967 ,对 3 有什么想法吗, |
|
In the end, I am still new to the codebase, and do some superficial refactoring as I encounter issues. I think it will take a long time to warm up to this kind of work. I found that when adding a new transport, a lot of new interfaces have to be added. I wish that instead of parsing JSON, building a protobuf struct from it, there is instead one config struct per transport and that's it. This is my personal vendetta. I haven't done any research on how to achieve this. Originally I said, I want to remove protobuf, but I don't think it's realistic anymore unless there is a decision to remove grpc API and replace it with some JSON/REST API. Right now I am trying to compile I also noticed that there are wasm-related build tags in the code, but the codebase definitely does not compile to wasm at all. Anyway, all of this is totally unrelated, but I might propose a PR to split up the config-related code so that some parts can be compiled separately. I don't know what exactly to do yet. |
inbound/outbound/detours
|
These things seem entirely undocumented, make it a hard error to set them.