Skip to content

refactor file & format array to an struct array#3687

Merged
RPRX merged 2 commits intoXTLS:mainfrom
jadeydi:file-with-format
Aug 16, 2024
Merged

refactor file & format array to an struct array#3687
RPRX merged 2 commits intoXTLS:mainfrom
jadeydi:file-with-format

Conversation

@jadeydi
Copy link
Contributor

@jadeydi jadeydi commented Aug 16, 2024

No description provided.

@jadeydi
Copy link
Contributor Author

jadeydi commented Aug 16, 2024

目的主要是方便阅读代码,如果是把 file 跟 format 放到两个数组,做为两个参数,通常不会认为这两者有关联,会增加理解的成本

@RPRX RPRX requested a review from yuhan6665 August 16, 2024 02:52
@RPRX
Copy link
Member

RPRX commented Aug 16, 2024

@yuhan6665 你 approve 后,我想个合适的标题

Copy link
Member

@yuhan6665 yuhan6665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@RPRX RPRX merged commit 1562e1f into XTLS:main Aug 16, 2024
zxspirit pushed a commit to zxspirit/Xray-core that referenced this pull request Aug 30, 2024
leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this pull request Oct 29, 2024
it2konst pushed a commit to it2konst/gametunnel-core that referenced this pull request Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants