Merged
Conversation
yuhan6665
reviewed
Jul 8, 2024
transport/internet/config.proto
Outdated
|
|
||
| bool tcp_mptcp = 19; | ||
|
|
||
| map<int32, int32> customSockopt = 20; |
Member
There was a problem hiding this comment.
I think it is a good idea, please make it more generic that user should be able to define level (2nd param in .Setsockopt()) as well. Also it should support different value types.. Maybe something like
message Custom {
int64 level;
int64 opt;
int32 type;
string value;
}
Member
Author
|
level是可以的 type是什么() |
Member
Author
|
如果是说syscall包里的string和byte 可以这么写 反正如果输的不正确直接在后面抛错误就行了 |
Member
Author
|
改成了这样 支持了 value 和 int str选项 值全部改成了string 因为如果是int的话默认值是0 但是有时候一些值就是要设置为0 不知道到底是用户设置为0还是没填 所以改成字符串 检测空就是没填 |
Member
|
Please keep value in one field, otherwise it is confusing what is being set. eg. |
Member
Author
|
OK, it's doneee |
Member
|
strconv.Atoi 的错误可能需要返回。。不过先这样吧 感谢佬! |
This was referenced Jul 22, 2024
leninalive
pushed a commit
to amnezia-vpn/amnezia-xray-core
that referenced
this pull request
Oct 29, 2024
* Add custom sockopt * Add custom level * Change field * Sth left
4 tasks
it2konst
pushed a commit
to it2konst/gametunnel-core
that referenced
this pull request
Mar 1, 2026
* Add custom sockopt * Add custom level * Change field * Sth left
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3516
虽然支持一个sockopt没有意义 但是支持自定义或许有_(吗)_
举栗